Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

veriT: Fix build on macos #178627

Merged
merged 1 commit into from
Jun 22, 2022
Merged

veriT: Fix build on macos #178627

merged 1 commit into from
Jun 22, 2022

Conversation

hrajchert
Copy link
Contributor

Description of changes

The veriT package was broken on Darwin as it was using the clang stdenv while it needed gcc.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@shlevy shlevy added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 22, 2022
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 22, 2022
@ofborg ofborg bot requested a review from gebner June 22, 2022 20:12
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 22, 2022
@shlevy shlevy merged commit 6709bf9 into NixOS:master Jun 22, 2022
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #178636 for release-22.05.

@github-actions
Copy link
Contributor

The process '/usr/bin/git' failed with exit code 1

@hrajchert hrajchert deleted the verit-macos-fix branch June 24, 2022 12:29
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrajchert @gebner @shlevy @Janik-Haag